Cheat Engine

KéKéCoRe · Posted: Fri Mar 10, 2017 1:49 pm Post subject: Github Cheat Engine Official

I do not see my program changes in Github, on the cover page of cheat engine Github ..

I would like it to be included officially. It's mostly display bug fixes.

I have seen some errors and I corrected them but I see that on my personal page, cheat engine gitbub ..

https://github.com/KeKeCoRe

https://github.com/KeKeCoRe/cheat-engine/branches

So, that I got shit to find, and to help for its to be much more comprehensible.Thank you,again! Smile

Csimbi · Posted: Fri Mar 10, 2017 1:56 pm Post subject:

Not sure what your goal is but good luck!

STN · Posted: Fri Mar 10, 2017 2:10 pm Post subject:

Maybe DB didn't consider them important to be included to CE?

KéKéCoRe · Posted: Fri Mar 10, 2017 2:11 pm Post subject: Csimbi's answer & STN's answer

Csimbi's answer
I doubt it ah! But it's just level fixes for translations! Above all, the one in French as well as to translate and correctly, and that its is understandable and worthy of quality.

Otherwise, I know nothing programming, finally a little but in the field of electrotechnical automation. But it is the same, but different.

I have just added a picture on the button, 'set shortcut' the one I corrected, if you download my translation in French, in the 'settings' section 'key shortcuts' a button and too small, and I found it and I corrected the problem but what I do not see my correction on cheat engine Github. I put strength to translate well and that its really professional as translation.

STN's answer
It's just a fix for displaying the translation, it is ugly if not, especially that it's free more! So I do not see why, its should not be taken into account especially that it is to correct some minor bug so that its is prettier and more professional for a program like this

Csimbi · Posted: Fri Mar 10, 2017 2:18 pm Post subject:

You do understand that the changes you make in your fork are visible only in your own build, right?
Also, none of the changes in CE are automatically taken over to your fork since you made your own fork.

KéKéCoRe · Posted: Fri Mar 10, 2017 2:56 pm Post subject:

Yes, that's it, and I'd just like the masters in the official
And it will surely still have corrections for later still as I have not translated everything
Especially as I make the corrections on the sheet of the official but it does not put, that at home

bengast · Posted: Fri Mar 10, 2017 2:58 pm Post subject:

Just download the branch they're working on and then commit all your changes and then DB will see them.

Dark Byte · Posted: Fri Mar 10, 2017 3:01 pm Post subject:

you need to send pull requests on github to my branch, then i can review and appky them if they are good. ( on my view:
https://github.com/cheat-engine/cheat-engine/pulls?q=is%3Apr+is%3Aclosed )

also adjusting width and height is not a good solution. instead autosize should be used and anchors on the controls and around them should be applied.

e.g override the font and set the the size to 19. that will usually also show translation error spots