Cheat Engine

[wofo]

Hi, I am starting in delphi and wanting to learn how to make trainers. Some1 gave me this code

[lurc]

i recommend actually learning the language before going into anything advanced...

[Devilizer]

[slippppppppp]

var
Form1: TForm1; // doesnt have to be here
WindowName : integer; // window name declared as an integer
ProcessId : integer; // process declared as integer
ThreadId : integer; // ThreadIddeclared as integer
buf : PChar; // bug declared as a Pchar
HandleWindow : Integer; // Handle Window declared as integer
write : cardinal; // write declared as cardinal

implementation

{$R WindowsXP.RES}

Const // constants, ie symbol = XXX
WindowTitle = 'GTA: Vice City'; // WindowTitle's value
Address = 8223480; // address to write to
NumberOfBytes = 2; // bytes for room
Banshee = 159; // a random name with value, ie: the value to get banshee is 159?

{$R *.dfm}

procedure TForm1.ListBox1Click(Sender: TObject);
begin
If ListBox1.Selected [0] then
begin
WindowName := FindWindow(nil,WindowTitle); // WindowName's value = result of FindWindow 'GTA: Vice City'

If WindowName = 0 then // if the window cannot be found
begin
MessageDlg('Vice City must be running. Run it now, and then try again.', mtwarning,[mbOK],0) // show an error message
end
else // if window is found
ThreadId := GetWindowThreadProcessId(WindowName,@ProcessId); // ThreadId's value is result of GetWindowThreadProcessId, gets the PID of the WindowName.

HandleWindow := OpenProcess(PROCESS_ALL_ACCESS,False,ProcessId);
// Handle Window is the resulting value of Opening the process, PID, and giving you all access
GetMem(buf,1); // get memory, into buf
buf^ := Chr(Banshee); // puts the value of banshee into buf
WriteProcessMemory(HandleWindow,ptr(Address),buf,N umberOfBytes,write); // Writes the process's memory, the address and the buf value.

FreeMem(buf); // freememory of bug
closehandle(HandleWindow); // close the window's handle
end;

[rapion124]

Lmao no wonder it doesn't work... I can find like 10 places where this code, if compiled, would totally bomb.

HandleWindow not declared as THandle,
ProcessID doesn't have a value...
ThreadID doesn't need to be declared at all
WindowName should be compared to NULL not 0
Improper parameters for APIs
Closing a handle that isn't valid will crash
No block after the else statement so all code after 1 line after else will run.



Conclusion, no way this will work. Learn the language first, not just follow one of Kaspersky's tutorials and replace stuff.

[HolyBlah]

[DeletedUser14087]

slippp, Form1: TForm1; // doesnt have to be here, wtf ?