MantisBT - Cheat Engine
View Issue Details
0000299Cheat Enginepublic2013-11-19 21:542014-02-13 07:12
ReporterCsimbi 
Assigned ToDark Byte 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0000299: CE 6.3 - Order of editboxes for pointer rescan dialog's 'End address'
DescriptionIn the pointer re-scan dialog, when you tick 'must end with offsets', an editbox appears. I enter an offset and rescan the results.
I press CTRL+R to rescan again and click the 'Add' button to add more offsets.
The new editbox appears at the bottom, and the previously present offsets remain it place. This means, that in order to enter a new offset before the existing list, I have to copy each and every offset manually one box below.
I attached a screenshot to illustrate what happens after I click 'Add' button.

There are three solutions that I can think off the top of my head:
 - editboxes to appear in reverse order (i.e. first editbox contains last offset), so the newly appearing editbox is ok at the end as that's the right spot for the 'previous' offset,
 - new editbox appears at the top, and when it does, CE updates the 'Top' and 'Left' coordinates of all existing editboxes so they move down, making space for the editbox appearing on top,
 - new editbox appears at the bottom, but when it does, CE copies all offsets one box down automatically.
And, of course, the 'Remove' button would need to do the opposite.

Each of these options have their own ups and downs, I'm sure you'll weigh them make a good choice - maybe even come up with a better solution.

Thank you for considering.
TagsNo tags attached.
Attached Filespng CE-RescanEndOffsets.png (10,233) 2013-11-19 21:54
http://cheatengine.org/mantis/file_download.php?file_id=101&type=bug
png

Notes
(0000626)
Csimbi   
2013-11-19 22:07   
(Last edited: 2013-11-19 22:14)
Forgot: The pointer scan dialog does this with reverse-ordered editboxes; you might want to adopt that same solution on the rescan dialog for the sake of consistency.

(0000628)
mgr_inz_Player   
2013-11-20 15:24   
(Last edited: 2013-11-20 15:28)
about "reverse-ordered editboxes", I was thinking about adding additional label(s) which will move always next to corresponding editbox (L next to last offset, F next to first offset).

MSPaint example:
http://i.imgur.com/oxKbwMt.png

and
http://i.imgur.com/fR7r6nY.png

(0000631)
mgr_inz_Player   
2013-11-20 20:14   
(Last edited: 2013-11-20 22:28)
About "must end editboxes" inside rescan window, we can change this line:
http://code.google.com/p/cheat-engine/source/browse/trunk/Cheat+Engine/frmRescanPointerUnit.pas#470

to
"endoffsets.Insert(0,e);"

and small modification at line 481 (delete element at zero)

Edit:
Maybe DB will apply this patch for rescan window: http://pastebin.com/jwQf50Rz
It changes "must end" editbox creation and changes position of "must end" add(remove) button.
Editbox order is still the same as original CE6.3, so it will not mislead new users.

Plus, this patch adds two labels when needed:
- "First offset" so you will know which editbox is first ("must start")
- "Last offset" so you will know which editbox is last ("must end")


Demo:
http://i.imgur.com/tvthHjx.gif

(0000632)
Csimbi   
2013-11-20 22:52   
That Demo GIF is great; that'd be great; thanks!
(0000658)
Dark Byte   
2014-02-13 07:12   
implemented

Issue History
2013-11-19 21:54CsimbiNew Issue
2013-11-19 21:54CsimbiFile Added: CE-RescanEndOffsets.png
2013-11-19 22:07CsimbiNote Added: 0000626
2013-11-19 22:14CsimbiNote Edited: 0000626
2013-11-20 15:24mgr_inz_PlayerNote Added: 0000628
2013-11-20 15:25mgr_inz_PlayerNote Edited: 0000628
2013-11-20 15:28mgr_inz_PlayerNote Edited: 0000628
2013-11-20 20:14mgr_inz_PlayerNote Added: 0000631
2013-11-20 20:16mgr_inz_PlayerNote Edited: 0000631
2013-11-20 20:19mgr_inz_PlayerNote Edited: 0000631
2013-11-20 22:01mgr_inz_PlayerNote Edited: 0000631
2013-11-20 22:28mgr_inz_PlayerNote Edited: 0000631
2013-11-20 22:52CsimbiNote Added: 0000632
2014-02-13 07:12Dark ByteNote Added: 0000658
2014-02-13 07:12Dark ByteStatusnew => resolved
2014-02-13 07:12Dark ByteResolutionopen => fixed
2014-02-13 07:12Dark ByteAssigned To => Dark Byte